lkml.org 
[lkml]   [2009]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Performance overhead of paravirt_ops on native identified
    Chuck Ebbert wrote:
    > On Wed, 13 May 2009 17:16:55 -0700
    > Jeremy Fitzhardinge <jeremy@goop.org> wrote:
    >
    >
    >> Paravirt patching turns all the pvops calls into direct calls, so
    >> _spin_lock etc do end up having direct calls. For example, the compiler
    >> generated code for paravirtualized _spin_lock is:
    >>
    >> <_spin_lock+0>: mov %gs:0xb4c8,%rax
    >> <_spin_lock+9>: incl 0xffffffffffffe044(%rax)
    >> <_spin_lock+15>: callq *0xffffffff805a5b30
    >> <_spin_lock+22>: retq
    >>
    >> The indirect call will get patched to:
    >> <_spin_lock+0>: mov %gs:0xb4c8,%rax
    >> <_spin_lock+9>: incl 0xffffffffffffe044(%rax)
    >> <_spin_lock+15>: callq <__ticket_spin_lock>
    >> <_spin_lock+20>: nop; nop /* or whatever 2-byte nop */
    >> <_spin_lock+22>: retq
    >>
    >>
    >
    > Can't those calls be changed to jumps?
    >

    In this specific instance of this example, yes. But if you start
    enabling various spinlock debug options then there'll be code following
    the call. It would be hard for the runtime patching machinery to know
    when it would be safe to do the substitution.

    J



    \
     
     \ /
      Last update: 2009-05-22 00:51    [W:0.026 / U:121.584 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site