lkml.org 
[lkml]   [2009]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] MFD: Add U300 AB3100 core support v3
From
Thanks Ben, v4 due soon..

2009/5/20 Ben Dooks <ben-linux@fluff.org>:

>> +#define AB3100_DEVICE(devname, devid, regstart, regend) \
>> +static struct resource ab3100_##devname##_resource[] = { \
>> + { \
>> + .start = regstart, \
>> + .end = regend, \
>> + .flags = IORESOURCE_IO, \
>> + } \
>
> is IORESOURCE_IO a good idea here, we may need to add some form of
> flag to say 'generic data' and for the driver core to not try and
> register it with any of the ioport or iomem structures.

I'll remove it for the time being, it's not used currently anyway.

Yell if you want me to create a patch to include/linux/platform_devices.h
for this too...

>> + {
>> + .id = 0xc8,
>> + .name = "P2B/R2B"
>> + },
>
> doing }, { would makes these shorter still.

Yeah CodingStyle actually say so if I read it closely, I'll fix.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2009-05-20 10:39    [W:0.075 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site