lkml.org 
[lkml]   [2009]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] Time out for possible dead loops during queued invalidation wait
Two loops in qi_submit_sync() do not have time out. If hardware can not finish
the queued invalidation for some reason, the loops could end up in dead loops
without any hint for what is going on. I add time out for the loops and report
warning when time out happens.

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>

---
dmar.c | 12 ++++++++++++
1 files changed, 12 insertions(+)
diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
index fa3a113..95baacd 100644
--- a/drivers/pci/dmar.c
+++ b/drivers/pci/dmar.c
@@ -637,6 +637,7 @@ int qi_submit_sync(struct qi_desc *desc, struct intel_iommu *iommu)
struct qi_desc *hw, wait_desc;
int wait_index, index;
unsigned long flags;
+ cycles_t start_time;

if (!qi)
return 0;
@@ -644,8 +645,13 @@ int qi_submit_sync(struct qi_desc *desc, struct intel_iommu *iommu)
hw = qi->desc;

spin_lock_irqsave(&qi->q_lock, flags);
+ start_time = get_cycles();
while (qi->free_cnt < 3) {
spin_unlock_irqrestore(&qi->q_lock, flags);
+ if (DMAR_OPERATION_TIMEOUT < (get_cycles() - start_time)) {
+ WARN(1, "No space in invalidation queue.\n");
+ return -ENOSPC;
+ }
cpu_relax();
spin_lock_irqsave(&qi->q_lock, flags);
}
@@ -675,6 +681,7 @@ int qi_submit_sync(struct qi_desc *desc, struct intel_iommu *iommu)
*/
writel(qi->free_head << 4, iommu->reg + DMAR_IQT_REG);

+ start_time = get_cycles();
while (qi->desc_status[wait_index] != QI_DONE) {
/*
* We will leave the interrupts disabled, to prevent interrupt
@@ -687,6 +694,11 @@ int qi_submit_sync(struct qi_desc *desc, struct intel_iommu *iommu)
if (rc)
goto out;

+ if (DMAR_OPERATION_TIMEOUT < (get_cycles() - start_time)) {
+ WARN(1, "Queued invalidation can not complete.\n");
+ goto out;
+ }
+
spin_unlock(&qi->q_lock);
cpu_relax();
spin_lock(&qi->q_lock);

\
 
 \ /
  Last update: 2009-05-20 19:45    [from the cache]
©2003-2011 Jasper Spaans