lkml.org 
[lkml]   [2009]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] crypto: hifn_795x - fix __dev{init,exit} markings
Hi Mike.

On Mon, May 18, 2009 at 03:51:50AM -0400, Mike Frysinger (vapier@gentoo.org) wrote:
> The remove member of the pci_driver hifn_pci_driver uses __devexit_p(),
> so the remove function itself should be marked with __devexit. And where
> there be __devexit on the remove, so is there __devinit on the probe.
>
> Similarly, the module_init/module_exit functions should be declared with
> plain __init/__exit markings, not the hotplug __dev{init,exit} ones.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Evgeniy Polyakov <zbr@ioremap.net>
> CC: Patrick McHardy <kaber@trash.net>

Looks good, thank you Mike.
Ack. Herbert, please apply.

--
Evgeniy Polyakov


\
 
 \ /
  Last update: 2009-05-20 16:59    [W:0.048 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site