Messages in this thread | | | Date | Wed, 20 May 2009 18:56:23 +0400 | From | Evgeniy Polyakov <> | Subject | Re: [PATCH] crypto: hifn_795x - fix __dev{init,exit} markings |
| |
Hi Mike.
On Mon, May 18, 2009 at 03:51:50AM -0400, Mike Frysinger (vapier@gentoo.org) wrote: > The remove member of the pci_driver hifn_pci_driver uses __devexit_p(), > so the remove function itself should be marked with __devexit. And where > there be __devexit on the remove, so is there __devinit on the probe. > > Similarly, the module_init/module_exit functions should be declared with > plain __init/__exit markings, not the hotplug __dev{init,exit} ones. > > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > CC: Evgeniy Polyakov <zbr@ioremap.net> > CC: Patrick McHardy <kaber@trash.net>
Looks good, thank you Mike. Ack. Herbert, please apply.
-- Evgeniy Polyakov
| |