lkml.org 
[lkml]   [2009]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 01/19] Add XHFC support for embedded Speech-Design board to hfcmulti
Date
On Mittwoch, 20. Mai 2009 13:38:13 Andi Kleen wrote:
> Hi Karsten,
>
> > This config is not set by mISDN, it is set by somepowerpc sub arch.
>
> That still seems like a rather quirky way to do this then, making
> drivers dependent on specific architectures. This kind
> of thing lead to ifdef jungles in the past, hopefully not done
> again in new drivers.

Andy, thanks for you comments.

Yes I did not like this part as well and this was the reason why I did not
include this patch in my previous update in January. I only fixed some
codestyle issues now.

Let discuss this with the author (CC'ed now).

>
> Standard ways to handle this:
> - If the driver needs something special only this architecture can
> provide make the architecture set a special HAS... config option.
> - Provide a special asm include file that is stubbed out
> by other architectures.
> - Put the arch specific code in another file and make that dependent on the
> HAS_... symbol in the Makefile.

Do you have a pointer to a good example here ?

It seems that this architecture (used by an existing embedded board) have
very specific IO method to this hardware so this should go into a separate
file.

Karsten



\
 
 \ /
  Last update: 2009-05-20 14:21    [from the cache]
©2003-2011 Jasper Spaans