Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH] Add CONFIG_VFAT_NO_CREATE_WITH_LONGNAMES option | Date | Sat, 02 May 2009 19:32:11 +0900 |
| |
tridge@samba.org writes:
> OGAWA Hirofumi writes: > > I'll answer to only technical part. This patch creates different name > > internally, without renaming dcache. Are you really sure if that's ok? > > The name handling should be the same as the existing code path where > goto shortname is done after vfat_create_shortname() in > vfat_build_slots() (ie. when the name conformed to 8.3). > > What situation are you thinking of which this would cause a problem?
At this answer, I was missing the (is_shortname == 0).
However, if filename contains the chars in vfat_replace_char(). It will have similar problem. In this case, this patch creates the dir entry without longname. So, it wouldn't match to dcache and real dir entries. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |