lkml.org 
[lkml]   [2009]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC][PATCH 17/35] sparc: create ptemap.h
    From
    Date
    On Sat, 2009-05-02 at 07:02 +0000, Daniel K. wrote:
    > Dave Hansen wrote:
    > > -/* Certain architectures need to do special things when pte's
    > > - * within a page table are directly modified. Thus, the following
    > > - * hook is made available.
    > > - */
    >
    > This is FUBAR'ed, The comment refers to the BTFIXUPDEF_CALL below, and should not
    > be moved to asm/ptemap.h

    Thanks for looking through this. I've fixed this up in my most recent
    version.

    > > + * This shortcut works on sun4m (and sun4d) because the nocache area is static,
    > > + * and sun4c is guaranteed to have no highmem anyway.
    > > + */
    >
    > Broken comment.
    >
    > > +#define pte_offset_map(d, a) pte_offset_kernel(d,a)
    > > +#define pte_offset_map_nested(d, a) pte_offset_kernel(d,a)
    > > +
    > > +#define pte_unmap(pte) do{}while(0)
    > > +#define pte_unmap_nested(pte) do{}while(0)
    > > +
    > > +#endif
    > > +
    > > +#endif /* _SPARC_ASM_PTEMAP_H *//*
    >
    > Broken comment.
    >
    > I realize this is going away in the end, but all the interim steps should
    > compile, to aid bisection.

    Yup, absolutely. This is fixed up now, too.

    -- Dave



    \
     
     \ /
      Last update: 2009-05-02 23:45    [W:0.022 / U:59.672 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site