Messages in this thread | | | Date | Tue, 19 May 2009 11:00:49 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] include KERN_* constant in printk calls |
| |
* Chris Sanford <crsanford@gmail.com> wrote:
> Add the KERN_CONT constant to two printk calls. > > Signed-off-by: Chris Sanford <crsanford@gmail.com> > > --- > > > diff --git a/kernel/sched.c b/kernel/sched.c > index 26efa47..6a2ed16 100644 > --- a/kernel/sched.c > +++ b/kernel/sched.c > @@ -7319,7 +7319,7 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level, > printk(KERN_DEBUG "%*s domain %d: ", level, "", level); > > if (!(sd->flags & SD_LOAD_BALANCE)) { > - printk("does not load-balance\n"); > + printk(KERN_CONT "does not load-balance\n"); > if (sd->parent) > printk(KERN_ERR "ERROR: !SD_LOAD_BALANCE domain" > " has parent"); > @@ -7340,7 +7340,7 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level, > printk(KERN_DEBUG "%*s groups:", level + 1, ""); > do { > if (!group) { > - printk("\n"); > + printk(KERN_CONT "\n"); > printk(KERN_ERR "ERROR: group is NULL\n"); > break;
Please use pr_cont() - and while at it, perhaps convert all other printk()s in sched.c from KERN_* to the pr_*() notation as well?
Thanks,
Ingo
| |