lkml.org 
[lkml]   [2009]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 19/19] isdn: get_free_devid() failure ignored
    From
    Date
    From: Roel Kluin <roel.kluin@gmail.com>

    dev->id is unsigned so a get_free_devid() error is ignored.

    Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Karsten Keil <keil@b1-systems.de>
    ---
    drivers/isdn/mISDN/core.c | 8 ++++----
    1 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/isdn/mISDN/core.c b/drivers/isdn/mISDN/core.c
    index 9426c98..21d34be 100644
    --- a/drivers/isdn/mISDN/core.c
    +++ b/drivers/isdn/mISDN/core.c
    @@ -214,7 +214,7 @@ get_free_devid(void)
    if (!test_and_set_bit(i, (u_long *)&device_ids))
    break;
    if (i > MAX_DEVICE_ID)
    - return -1;
    + return -EBUSY;
    return i;
    }

    @@ -224,10 +224,10 @@ mISDN_register_device(struct mISDNdevice *dev,
    {
    int err;

    - dev->id = get_free_devid();
    - err = -EBUSY;
    - if (dev->id < 0)
    + err = get_free_devid();
    + if (err < 0)
    goto error1;
    + dev->id = err;

    device_initialize(&dev->dev);
    if (name && name[0])
    --
    1.6.0.2


    \
     
     \ /
      Last update: 2009-05-19 19:15    [W:0.021 / U:153.004 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site