lkml.org 
[lkml]   [2009]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] istallion: add missing __devexit marking
Hi Mike,

Mike Frysinger wrote:
> The remove member of the pci_driver stli_pcidriver uses __devexit_p(),
> so the remove function itself should be marked with __devexit. Even
> more so considering the probe function is marked with __devinit.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Greg Ungerer <gerg@uclinux.org>

Looks ok to me:

Acked-by: Greg Ungerer <gerg@uclinux.org>


> ---
> drivers/char/istallion.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/istallion.c b/drivers/char/istallion.c
> index fff19f7..e8392c2 100644
> --- a/drivers/char/istallion.c
> +++ b/drivers/char/istallion.c
> @@ -3785,7 +3785,7 @@ err:
> return retval;
> }
>
> -static void stli_pciremove(struct pci_dev *pdev)
> +static void __devexit stli_pciremove(struct pci_dev *pdev)
> {
> struct stlibrd *brdp = pci_get_drvdata(pdev);
>

--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com


\
 
 \ /
  Last update: 2009-05-19 07:37    [W:0.036 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site