Messages in this thread | | | Date | Tue, 19 May 2009 15:35:16 +1000 | From | Greg Ungerer <> | Subject | Re: [PATCH] istallion: add missing __devexit marking |
| |
Hi Mike,
Mike Frysinger wrote: > The remove member of the pci_driver stli_pcidriver uses __devexit_p(), > so the remove function itself should be marked with __devexit. Even > more so considering the probe function is marked with __devinit. > > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > CC: Greg Ungerer <gerg@uclinux.org>
Looks ok to me:
Acked-by: Greg Ungerer <gerg@uclinux.org>
> --- > drivers/char/istallion.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/char/istallion.c b/drivers/char/istallion.c > index fff19f7..e8392c2 100644 > --- a/drivers/char/istallion.c > +++ b/drivers/char/istallion.c > @@ -3785,7 +3785,7 @@ err: > return retval; > } > > -static void stli_pciremove(struct pci_dev *pdev) > +static void __devexit stli_pciremove(struct pci_dev *pdev) > { > struct stlibrd *brdp = pci_get_drvdata(pdev); >
-- ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
| |