lkml.org 
[lkml]   [2009]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 30/32] union mount: ext2 fallthru support
On Mon, May 18, Andreas Dilger wrote:

> For enums like this that require specific constant on-disk values
> I prefer being safe:
>
> enum {
> EXT2_FT_UNKNOWN = 0,
> EXT2_FT_REG_FILE = 1,
> EXT2_FT_DIR = 2,
> EXT2_FT_CHRDEV = 3,
> EXT2_FT_BLKDEV = 4,
> EXT2_FT_FIFO = 5,
> EXT2_FT_SOCK = 6,
> EXT2_FT_SYMLINK = 7,
> EXT2_FT_WHT = 8,
> EXT2_FT_FALLTHRU = 9,
> EXT2_FT_MAX
>
>
> It probably also makes sense to include a patch for ext3/ext4 to ensure
> these values are not used by some unrelated feature.

In ext3 these are preprocessor defines. IIRC defines and enums are identical
for C (both an int) so I leave this untouched and just add the new filetypes,
right?

Thanks,
Jan


\
 
 \ /
  Last update: 2009-05-19 11:45    [from the cache]
©2003-2011 Jasper Spaans