Messages in this thread | | | Subject | Re: [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr_notice( | From | Krzysztof Halasa <> | Date | Mon, 18 May 2009 19:18:52 +0200 |
| |
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> writes:
>> Though I think most people would agree that the latter is much better, >> no? > > No, it just hides the real issue:
I didn't say it's best. Just better :-)
>> I think removal (rewording) of this rule has already been agreed upon, >> though not exactly yet codified. > > This is not a strict rule but in 99% cases it shows that the code could > be improved further without >80 chars lines.
I don't have the stat numbers handy but the established idea is that since the texts could be up to 80-chars long (and it's a good thing), the printk line needed to output them has to be longer. IOW, breaking the text into pieces is worse. Obviously, that doesn't mean one can't do better. -- Krzysztof Halasa
| |