lkml.org 
[lkml]   [2009]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr_notice(
From
Date
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> writes:

>> Though I think most people would agree that the latter is much better,
>> no?
>
> No, it just hides the real issue:

I didn't say it's best. Just better :-)

>> I think removal (rewording) of this rule has already been agreed upon,
>> though not exactly yet codified.
>
> This is not a strict rule but in 99% cases it shows that the code could
> be improved further without >80 chars lines.

I don't have the stat numbers handy but the established idea is that
since the texts could be up to 80-chars long (and it's a good thing),
the printk line needed to output them has to be longer.
IOW, breaking the text into pieces is worse. Obviously, that doesn't
mean one can't do better.
--
Krzysztof Halasa


\
 
 \ /
  Last update: 2009-05-18 19:21    [from the cache]
©2003-2011 Jasper Spaans