Messages in this thread | | | Date | Mon, 18 May 2009 13:15:24 +0200 | From | Cornelia Huck <> | Subject | Re: [PATCH 2/2] driver core:firmware:fix request_firmware_nowait |
| |
On Sat, 16 May 2009 21:54:18 +0800, tom.leiming@gmail.com wrote:
> @@ -646,14 +646,12 @@ request_firmware_nowait( > .uevent = uevent, > }; > > - task = kthread_run(request_firmware_work_func, fw_work, > - "firmware/%s", name); > - > - if (IS_ERR(task)) { > + ret = async_run_inatomic(request_firmware_work_func, fw_work); > + if (ret) { > fw_work->cont(NULL, fw_work->context); > module_put(fw_work->module); > kfree(fw_work); > - return PTR_ERR(task); > + return ret;
You change the return code from an usual error code to a boolean value here...
> } > return 0; > }
| |