lkml.org 
[lkml]   [2009]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] driver core:firmware:fix request_firmware_nowait
On Sat, 16 May 2009 21:54:18 +0800,
tom.leiming@gmail.com wrote:

> @@ -646,14 +646,12 @@ request_firmware_nowait(
> .uevent = uevent,
> };
>
> - task = kthread_run(request_firmware_work_func, fw_work,
> - "firmware/%s", name);
> -
> - if (IS_ERR(task)) {
> + ret = async_run_inatomic(request_firmware_work_func, fw_work);
> + if (ret) {
> fw_work->cont(NULL, fw_work->context);
> module_put(fw_work->module);
> kfree(fw_work);
> - return PTR_ERR(task);
> + return ret;

You change the return code from an usual error code to a boolean value
here...

> }
> return 0;
> }



\
 
 \ /
  Last update: 2009-05-18 13:17    [W:0.084 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site