Messages in this thread | | | Date | Mon, 18 May 2009 11:40:53 +0900 | From | Minchan Kim <> | Subject | Re: [PATCH] mmtom: Prevent shrinking of active anon lru list in case of no swap space V3 |
| |
On Mon, 18 May 2009 10:34:04 +0800 Wu Fengguang <fengguang.wu@intel.com> wrote:
> On Thu, May 14, 2009 at 11:15:55PM +0900, MinChan Kim wrote: > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 2f9d555..621708f 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -1577,7 +1577,7 @@ static void shrink_zone(int priority, struct zone *zone, > > * Even if we did not try to evict anon pages at all, we want to > > * rebalance the anon lru active/inactive ratio. > > */ > > - if (inactive_anon_is_low(zone, sc)) > > + if (inactive_anon_is_low(zone, sc) && nr_swap_pages > 0) > > shrink_active_list(SWAP_CLUSTER_MAX, zone, sc, priority, 0); > > There's another "if (inactive_anon_is_low) shrink_active_list;" > occurrence to be fixed in balance_pgdat()? Otherwise:
I add Rik's comment. Of course, I agree his opinion.
"If we are close to running out of swap space, with swapins freeing up swap space on a regular basis, I believe we do want to do aging on the active pages, just so we can pick a decent page to swap out next time swap space becomes available."
> Acked-by: Wu Fengguang <fengguang.wu@intel.com>
Thanks for spending your time for my patch. Wu Fengguang :)
-- Kinds Regards Minchan Kim
| |