Messages in this thread Patch in this message | | | Date | Mon, 18 May 2009 08:54:12 +0800 | From | Li Zefan <> | Subject | Re: [PATCH] ftrace:fix check for return value of register_module_notifier |
| |
tom.leiming@gmail.com wrote: > From: Ming Lei <tom.leiming@gmail.com> > > return zero should be correct, so fix it. >
Nice catch.
We have those bogus warnings:
$ dmesg | grep Failed Failed to register trace ftrace module notifier Failed to register trace events module notifier
Could you fix the same bug in event_trace_init()?
> Signed-off-by: Ming Lei <tom.leiming@gmail.com> > --- > kernel/trace/ftrace.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index 5b606f4..140699a 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -2826,7 +2826,7 @@ void __init ftrace_init(void) > __stop_mcount_loc); > > ret = register_module_notifier(&ftrace_module_nb); > - if (!ret) > + if (ret) > pr_warning("Failed to register trace ftrace module notifier\n"); > > return;
| |