lkml.org 
[lkml]   [2009]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix print out of function which called WARN_ON()
On Sat, 16 May 2009, Linus Torvalds wrote:
>
> This patch not only avoids the warnings and gets the right caller
> information, it cleans up the code too:
>
> - it uses '%pS' instead of of sprint_symbol

> - char function[KSYM_SYMBOL_LEN];

This should be a big improvement, because that buffer on the stack
was netting lots of stale return addresses, printed out with ?s in
the warning's dump_stack(). I had been wanting to add a memset,
but your %pS should circumvent the need for that nicely.

Hugh


\
 
 \ /
  Last update: 2009-05-17 16:47    [W:0.082 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site