lkml.org 
[lkml]   [2009]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/18] swim: dequeue in-flight request
Sergei Shtylyov wrote:
> And without duplication:

Similar response as the if/else one on the other thread. Is it really
any significantly better? The 'duplication' here is basically one
liner after the peek/fetch change and when the duplication is minimal,
I usually find it clearer to put the loop condition at the while
clause itself. If you think it's significantly better, please go
ahead and submit the patch but to me the change you're proposing is
basically cosmetic and not even a clearly better one at that.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2009-05-16 16:41    [W:0.093 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site