lkml.org 
[lkml]   [2009]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] vmscan: merge duplicate code in shrink_active_list()
    Wu Fengguang wrote:
    > The "move pages to active list" and "move pages to inactive list"
    > code blocks are mostly identical and can be served by a function.
    >
    > Thanks to Andrew Morton for pointing this out.
    >
    > Note that buffer_heads_over_limit check will also be carried out
    > for re-activated pages, which is slightly different from pre-2.6.28
    > kernels. Also, Rik's "vmscan: evict use-once pages first" patch
    > could totally stop scans of active list when memory pressure is low.
    > So the net effect could be, the number of buffer heads is now more
    > likely to grow large.
    >
    > CC: Rik van Riel <riel@redhat.com>
    > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>

    Reviewed-by: Rik van Riel <riel@redhat.com>

    --
    All rights reversed.


    \
     
     \ /
      Last update: 2009-05-16 16:39    [W:0.022 / U:2.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site