Messages in this thread | | | Date | Sat, 16 May 2009 22:48:29 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH block#for-2.6.31 2/3] block: set rq->resid_len to blk_rq_bytes() on issue |
| |
Hello, Sergei.
Sergei Shtylyov wrote: >> Heh... there's a reason I mentioned the original commit. The original >> code was >> >> if (ret > 0) { >> /* positive number is the untransferred residual */ >> rsp->data_len = ret; >> req->data_len = 0; >> ret = 0; >> } else if (ret == 0) { >> rsp->data_len = 0; >> req->data_len = 0; >> } >> > > But still, > > req->data_len = 0; > > is common between both branches, so could be moved after the *if* > statement.
Yeah, sure, feel free to submit a patch, but I don't know. Does it even matter at all as long as the intention is clear?
Thanks.
-- tejun
| |