Messages in this thread | | | Subject | Re: [PATCH 23/30] loongson: CS5536 MFGPT as system clock source support | From | Wu Zhangjin <> | Date | Sat, 16 May 2009 09:15:41 +0800 |
| |
On Fri, 2009-05-15 at 17:39 -0700, john stultz wrote: > On Fri, May 15, 2009 at 3:23 PM, Wu Zhangjin <wuzhangjin@gmail.com> wrote: > > +static struct clocksource clocksource_mfgpt = { > > + .name = "mfgpt", > > + .rating = 1200, > > Minor nit. Please read the comment over the struct clocksource > definition in include/linux/clocksource.h for a guide to setting the > rating value for your clocksource. >
as the comment describes, just like the 8253 Timer, the precision of cs5536 mfgpt Timer is not good, the rating of it should be in the range of 100-199? Functional for real use, but not desired?
thanks! Wu Zhangjin
| |