Messages in this thread | | | Date | Fri, 15 May 2009 21:34:39 +0200 | From | Ingo Molnar <> | Subject | Re: [patch 1/2] ptrace, security: rename ptrace_may_access => ptrace_access_check |
| |
* Américo Wang <xiyou.wangcong@gmail.com> wrote:
> On Mon, May 11, 2009 at 9:39 PM, Ingo Molnar <mingo@elte.hu> wrote: > > > > I.e. any function name that can be plain-English answered with: > > 'yes' or 'no' is a red flag for a retval function. > > > > You cannot answer ptrace_access_check() with 'yes' or 'no'. You > > could if it was ptrace_access_ok() or ptrace_may_access. > > Aha, then why do you agree with this patch? You don't see > ptrace_access_check() returns bool?? :-)
except that it doesnt ...
Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |