lkml.org 
[lkml]   [2009]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] gs: missing parentheses


Roel Kluin wrote:
> `|' has a higher precedence than `?' so add parentheses.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/char/sx.c b/drivers/char/sx.c
> index 518f2a2..1f63add 100644
> --- a/drivers/char/sx.c
> +++ b/drivers/char/sx.c
> @@ -979,8 +979,8 @@ static int sx_set_real_termios(void *ptr)
> (I_IXANY(port->gs.port.tty) ? SP_TANY : 0) | SP_DCEN);
>
> sx_write_channel_byte(port, hi_break,
> - (I_IGNBRK(port->gs.port.tty) ? BR_IGN : 0 |
> - I_BRKINT(port->gs.port.tty) ? BR_INT : 0));
>
This looks correct to me.
> + (I_IGNBRK(port->gs.port.tty) ? BR_IGN : 0) |
> + (I_BRKINT(port->gs.port.tty) ? BR_INT : 0));
>
It may not want Interrupt and Ignore both at the same time on received
breaks.

>
> sx_write_channel_byte(port, hi_txon, START_CHAR(port->gs.port.tty));
> sx_write_channel_byte(port, hi_rxon, START_CHAR(port->gs.port.tty));
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
> Email Scanned for Virus & Dangerous Content by : www.CleanMailGateway.com
>
>
>


\
 
 \ /
  Last update: 2009-05-14 12:31    [W:0.029 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site