Messages in this thread | | | Date | Thu, 14 May 2009 16:05:21 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH v3] ftrace: add a tracepoint for __raise_softirq_irqoff() |
| |
Lai Jiangshan wrote: > Mathieu Desnoyers wrote: >> * Lai Jiangshan (laijs@cn.fujitsu.com) wrote: >>> Mathieu Desnoyers wrote:
>> #endif >> > > It's not needed for trace/events/irq.h > > Yes, it's a solution. > > But I don't think we have to do this, CREATE_TRACE_POINTS is > needed only _once_ for every <trace/events/xxxx.h> > > The .c file which defines CREATE_TRACE_POINTS can provide > (had provided likely) things like "#include <linux/interrupt.h>" > > See kernel/softirq.c: > #include <linux/interrupt.h> > ...... > ...... > #define CREATE_TRACE_POINTS > #include <trace/events/irq.h> > > I don't think it's a problem, CREATE_TRACE_POINTS is defined only > once for a <trace/events/xxxx.h>. >
Yes, I think Lai's argument is reasonable, the .c file which use ftrace already include the relevant head file. I will make a patch as your suggestions.
Thanks! ;-)
> Lai. > > >
| |