lkml.org 
[lkml]   [2009]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [patch 1/2] ptrace, security: rename ptrace_may_access => ptrace_access_check
From
On Mon, May 11, 2009 at 9:39 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> I.e. any function name that can be plain-English answered with:
> 'yes' or 'no' is a red flag for a retval function.
>
> You cannot answer ptrace_access_check() with 'yes' or 'no'. You
> could if it was ptrace_access_ok() or ptrace_may_access.


Aha, then why do you agree with this patch? You don't see
ptrace_access_check() returns bool?? :-)

I stand with Andrew, xxx_check() should not be a boolean function,
ptrace_may_access() looks very OK for me...


\
 
 \ /
  Last update: 2009-05-15 03:15    [W:0.060 / U:1.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site