Messages in this thread | | | Date | Fri, 15 May 2009 09:10:58 +0800 | Subject | Re: [patch 1/2] ptrace, security: rename ptrace_may_access => ptrace_access_check | From | Américo Wang <> |
| |
On Mon, May 11, 2009 at 9:39 PM, Ingo Molnar <mingo@elte.hu> wrote: > > I.e. any function name that can be plain-English answered with: > 'yes' or 'no' is a red flag for a retval function. > > You cannot answer ptrace_access_check() with 'yes' or 'no'. You > could if it was ptrace_access_ok() or ptrace_may_access.
Aha, then why do you agree with this patch? You don't see ptrace_access_check() returns bool?? :-)
I stand with Andrew, xxx_check() should not be a boolean function, ptrace_may_access() looks very OK for me...
| |