lkml.org 
[lkml]   [2009]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 13/51] i2c-algo-bit: Fix timeout test

    2.6.29-stable review patch. If anyone has any objections, please let us know.

    ------------------

    From: Dave Airlie <airlied@redhat.com>

    commit 0cdba07bb23cdd3e0d64357ec3d983e6b75e541f upstream

    When fetching DDC using i2c algo bit, we were often seeing timeouts
    before getting valid EDID on a retry. The VESA spec states 2ms is the
    DDC timeout, so when this translates into 1 jiffie and we are close
    to the end of the time period, it could return with a timeout less than
    2ms.

    Change this code to use time_after instead of time_after_eq.

    Signed-off-by: Dave Airlie <airlied@redhat.com>
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/i2c/algos/i2c-algo-bit.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/i2c/algos/i2c-algo-bit.c
    +++ b/drivers/i2c/algos/i2c-algo-bit.c
    @@ -104,7 +104,7 @@ static int sclhi(struct i2c_algo_bit_dat
    * chips may hold it low ("clock stretching") while they
    * are processing data internally.
    */
    - if (time_after_eq(jiffies, start + adap->timeout))
    + if (time_after(jiffies, start + adap->timeout))
    return -ETIMEDOUT;
    cond_resched();
    }



    \
     
     \ /
      Last update: 2009-05-15 00:51    [W:3.320 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site