Messages in this thread | | | Date | Thu, 14 May 2009 16:23:32 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 3/7] ide: merge ide_disk_special() into do_special() |
| |
Hello.
Joe Perches wrote:
>>While at it: >>- change debug printk() level to KERN_DEBUG >>- update documentation
>>There should be no functional changes caused by this patch.
>>Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> >>--- >> drivers/ide/ide-io.c | 44 ++++++++++++++++++-------------------------- >> 1 file changed, 18 insertions(+), 26 deletions(-)
>>Index: b/drivers/ide/ide-io.c >>=================================================================== >>--- a/drivers/ide/ide-io.c >>+++ b/drivers/ide/ide-io.c >>@@ -184,11 +184,28 @@ static void ide_tf_set_setmult_cmd(ide_d
> []
>>+#ifdef DEBUG >>+ printk(KERN_DEBUG "%s: %s: 0x%02x\n", drive->name, s->all); >>+#endif
> pr_debug?
Yes, and the number of arguments doesn't correspond to the number of the format specifiers.
WBR, Sergei
| |