lkml.org 
[lkml]   [2009]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] mmtom: Prevent shrinking of active anon lru list in case of no swap space V2
Date
> > 
> > Changelog since V2
> > o Add new function - can_reclaim_anon : it tests anon_list can be reclaim
> >
> > Changelog since V1
> > o Use nr_swap_pages <= 0 in shrink_active_list to prevent scanning of active anon list.
> >
> > Now shrink_active_list is called several places.
> > But if we don't have a swap space, we can't reclaim anon pages.
> > So, we don't need deactivating anon pages in anon lru list.
> >
> > Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
> > Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > Cc: Johannes Weiner <hannes@cmpxchg.org>
> > Cc: Rik van Riel <riel@redhat.com>
>
> looks good to me. thanks :)

Grr, my fault.



> static unsigned long shrink_list(enum lru_list lru, unsigned long nr_to_scan,
> struct zone *zone, struct scan_control *sc, int priority)
> {
> @@ -1399,7 +1412,7 @@ static unsigned long shrink_list(enum lru_list lru, unsigned long nr_to_scan,
> return 0;
> }
>
> - if (lru == LRU_ACTIVE_ANON && inactive_anon_is_low(zone, sc)) {
> + if (lru == LRU_ACTIVE_ANON && can_reclaim_anon(zone, sc)) {
> shrink_active_list(nr_to_scan, zone, sc, priority, file);
> return 0;

you shouldn't do that. if nr_swap_pages==0, get_scan_ratio return anon=0%.
then, this branch is unnecessary.






\
 
 \ /
  Last update: 2009-05-14 13:47    [from the cache]
©2003-2011 Jasper Spaans