lkml.org 
[lkml]   [2009]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[RFC][PATCH 0/6] PM/Hibernate: Rework memory shrinking (rev. 4)
Date
On Sunday 10 May 2009, Rafael J. Wysocki wrote:
> On Thursday 07 May 2009, Rafael J. Wysocki wrote:
> > On Thursday 07 May 2009, Rafael J. Wysocki wrote:
> > > Hi,
> > >
> > > The following patchset is an attempt to rework the memory shrinking mechanism
> > > used during hibernation to make room for the image. It is a work in progress
> > > and most likely it's going to be modified, but it has been discussed recently
> > > and I'd like to get comments on the current version.
> > >
> > > [1/5] - disable the OOM kernel after freezing tasks (this will be dropped if
> > > it's verified that we can avoid the OOM killing by using
> > > __GFP_FS|__GFP_WAIT|__GFP_NORETRY|__GFP_NOWARN
> > > in the next patches).
> > >
> > > [2/5] - drop memory shrinking from the suspend (to RAM) code path
> > >
> > > [3/5] - move swsusp_shrink_memory() to snapshot.c
> > >
> > > [4/5] - rework swsusp_shrink_memory() (to use memory allocations for applying
> > > memory pressure)
> > >
> > > [5/5] - allocate image pages along with the shrinking.
> >
> > Updated patchset follows.
>
> I the meantime I added a patch that attempts to computer the size of the hard
> core working set. I also had to rework the patch reworking
> swsusp_shrink_memory() so that it takes highmem into account.
>
> Currently, the patchset consists of the following patches:
>
> [1/6] - disable the OOM kernel after freezing tasks (this will be dropped if
> it's verified that we can avoid the OOM killing by using
> __GFP_FS|__GFP_WAIT|__GFP_NORETRY|__GFP_NOWARN
> in the next patches).
>
> [2/6] - drop memory shrinking from the suspend (to RAM) code path
>
> [3/6] - move swsusp_shrink_memory() to snapshot.c
>
> [4/6] - rework swsusp_shrink_memory() (to use memory allocations for applying
> memory pressure)
>
> [5/6] - allocate image pages along with the shrinking
>
> [6/6] - estimate the size of the hard core working set and use it as the lower
> limit of the image size.

This is the 4th (and hopefully final) version of the patchset reworking
hibernation memory shrinking. The patches have been rearranged and some of
them were modified to fix bugs etc.

[1/6] - drop memory shrinking from the suspend (to RAM) code path

[2/6] - move swsusp_shrink_memory() to snapshot.c

[3/6] - disable the OOM killer after freezing tasks (now it is done it a
simpler way)

[4/6] - rework swsusp_shrink_memory() to use memory allocations for applying
memory pressure)

[5/6] - do not release the preallocated image pages

[6/6] - estimate the minimum image size and use it to avoid attempting to free
too much memory too hard

IMO patches [1/6] and [2/6] are ready to go, so I'm going to add them to the
linux-next branch of the suspend tree.

Patch [3/6] in in mm, but it would be easier to handle [4/6] - [6/6] having
this patch in the suspend tree. Dunno. Andrew, what would you prefer to do
with it?

Patches [4/6] - [6/6] have been tested on a couple of boxes in different
configuration and no major problems have been found.

Comments welcome.

Thanks,
Rafael



\
 
 \ /
  Last update: 2009-05-13 10:49    [W:0.145 / U:17.524 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site