lkml.org 
[lkml]   [2009]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 8250: Don't restore NS16550 mode when console suspend is disabled
> > Surely if my console is at 230Kbits/sec then resuming it at a totally
> > different speed is going to break things for people even if it happens to
> > help XO debug ?
>
> The console is not in high speed mode when we suspend. The original
> commit (b5b82df6) just assumes that if it is a NATSEMI device, we
> should set it to high speed mode at resume w/o checking if that
> was the mode we were in when we suspended.

Then hard coding is no improvement either. It needs to restore the mode
that was present at suspend.

I'll update the 8250 Maintainers entry I suppose, I seem to have been
landed it as part of tty 8)


\
 
 \ /
  Last update: 2009-05-13 10:47    [W:0.056 / U:2.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site