Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [RFC] Replace the watermark-related union in struct zone with a watermark[] array V2 | Date | Wed, 13 May 2009 17:31:55 +0900 (JST) |
| |
> Changelog since V1 > o Use N_wmark_pages accessors instead of array accesses > > Patch page-allocator-use-allocation-flags-as-an-index-to-the-zone-watermark > from -mm added a union to struct zone where the watermarks could be accessed > with either zone->pages_* or a pages_mark array. The concern was that this > aliasing caused more confusion that it helped. > > This patch replaces the union with a watermark array that is indexed with > WMARK_* defines accessed via helpers. All call sites that use zone->pages_* > are updated to use the helpers for accessing the values and the array > offsets for setting. > > Signed-off-by: Mel Gorman <mel@csn.ul.ie>
looks good to me :)
| |