lkml.org 
[lkml]   [2009]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] swim3: use blk_end_request instead of blk_update_request
On Wed, May 13 2009, Kiyoshi Ueda wrote:
> Hi,
>
> Thank you for pointing this, Boaz!
>
> On 2009/05/13 0:27 +0900, Tejun Heo wrote:
> > Hello,
> >
> > Boaz Harrosh wrote:
> >> blk_update_request() was meant for request-based-multi-path, and not for swim3
> >> please see:
> >> 32fab448 block: add request update interface
> >>
> >> CC: Kiyoshi Ueda<k-ueda@ct.jp.nec.com>
> >>
> >> I think Tejun Heo was just using that in some recent block layer,
> >> transformation.
> >> Tejun?
> >
> > Yeah, conversion was easy that way. I think it's sane to have
> > blk_update_request() exported as long as request internal tinkering is
> > kept in block layer proper.
>
> blk_update_request() is needed for request-based dm to keep the request
> completion ordering in bottom-up, although request-based dm is not
> in upstream yet.
>
> Jens, please keep blk_update_request() exported.

I did, I applied the swim3 patches yesterday as well.

--
Jens Axboe



\
 
 \ /
  Last update: 2009-05-13 07:53    [W:0.065 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site