lkml.org 
[lkml]   [2009]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:irq/numa] x86: read apic ID in the !acpi_lapic case

* Yinghai Lu <yinghai@kernel.org> wrote:

> - return hard_smp_processor_id() >> index_msb;
> + return initial_apic_id >> index_msb;

> - unsigned apicid = hard_smp_processor_id();
> + unsigned apicid = cpu_has_apic ? hard_smp_processor_id() : c->apicid;

> - int apicid = hard_smp_processor_id();
> + int apicid = cpu_has_apic ? hard_smp_processor_id() : c->apicid;

Doesnt such a pattern call for the pushing of that distinction into
hard_smp_processor_id() instead? (after a careful review of all
hard_smp_processor_id() call-sites)

Ingo


\
 
 \ /
  Last update: 2009-05-13 15:17    [W:1.664 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site