Messages in this thread | | | Date | Tue, 12 May 2009 11:26:01 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v2] x86: fix ktermios-termio conversion |
| |
* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > hm, on x86 you could use get_user_try / get_user_ex() / > > get_user_catch() approach to linearize the dependencies and > > reduce register pressure. > > It used *once*, in a path that is never executed except by some > ancient binaries. It isn't worth the effort.
i know, and i tested the patch so i know what effects it has.
I never made any argument about inlining, it's obviously correct to have a use-once function inline.
My argument was very simple: the patch causes +150 bytes of bloat. The try/ex/catch method can help reduce register pressure and can reducethe size of code quite visibly.
Ingo
| |