lkml.org 
[lkml]   [2009]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 8250: Don't restore NS16550 mode when console suspend is disabled
> Hmm. I already applied this, but then after looking closer, I undid that. 
> Why? It looks buggy:

I'm a bit suprised that as tty and serial maintainer this is the first
time I see the patch.

> Isn't that second test wrong? Should it not be
>
> if ((up->capabilities & UART_NATSEMI) &&
> (console_suspend_enabled || !uart_console(&up->port)) {
>
> instead?

The patch seems totally bogus anyway. If the console was in a high speed
mode it should be resumed in a high speed mode. What are the actual
details here.

Surely if my console is at 230Kbits/sec then resuming it at a totally
different speed is going to break things for people even if it happens to
help XO debug ?


\
 
 \ /
  Last update: 2009-05-13 02:21    [W:0.081 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site