Messages in this thread | | | Date | Tue, 12 May 2009 15:05:52 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 3/6] powerpc: add memory map support to Freescale RapidIO block |
| |
On Tue, 12 May 2009 16:36:00 +0800 Li Yang <leoli@freescale.com> wrote:
> + align = (size < 0x1000) ? 0x1000 : 1 << (__ilog2(size - 1) + 1); > + > + /* Align the size */ > + if ((lstart + size) > (_ALIGN_DOWN(lstart, align) + align)) {
__ilog2() and _ALIGN_DOWN() are powerpc-specific functions. It would be preferable to use more general helpers if possible. ALIGN() and ilog2() might suit here.
| |