Messages in this thread | | | Date | Wed, 13 May 2009 00:31:08 +0900 | Subject | Re: [PATCH 0/2] swim3: use blk_end_request_all() | From | FUJITA Tomonori <> |
| |
On Wed, 13 May 2009 00:25:51 +0900 Tejun Heo <tj@kernel.org> wrote:
> Hello, > > FUJITA Tomonori wrote: > > This is against for-2.6.31 branch in the block tree. > > > > Tejun, don't we need to use blk_end_request_all() when we hit the > > maximum retry count in swim3_interrupt? Looks like we can't handle a > > request properly if we doesn't complete the request there. > > Ummm.... why so? Can you elaborate the bug scenario a bit? I was > trying to keep the original behavior whereever possible.
If when a request hits the maximum retry count and swim3_end_request_cur() doesn't complete the request there, where the request will be freed?
> > There are some other places to use blk_end_request_all if we need to. > > There are some other places where end_request_all can be used but I > hope there isn't any place where we should but aren't. :-) > > Thanks. > > -- > tejun > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |