lkml.org 
[lkml]   [2009]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] x86: introduce io_apic_irq_attr -v2
From
On Tue, May 12, 2009 at 3:32 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Yinghai Lu <yinghai@kernel.org> wrote:
>
>> +                             irq_attr->ioapic     = apic;
>> +                             irq_attr->ioapic_pin = mp_irqs[i].dstirq;
>> +                             irq_attr->trigger    = irq_trigger(i);
>> +                             irq_attr->polarity   = irq_polarity(i);
>
>> +                             irq_attr->ioapic     = apic;
>> +                             irq_attr->ioapic_pin = mp_irqs[i].dstirq;
>> +                             irq_attr->trigger    = irq_trigger(i);
>> +                             irq_attr->polarity   = irq_polarity(i);
>
> Shouldnt this be factored out ino a helper function?
>
set_io_apic_irq_attr()?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-05-12 17:19    [W:0.086 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site