Messages in this thread | | | Date | Tue, 12 May 2009 08:17:07 -0700 | Subject | Re: [PATCH] x86: introduce io_apic_irq_attr -v2 | From | Yinghai Lu <> |
| |
On Tue, May 12, 2009 at 3:32 AM, Ingo Molnar <mingo@elte.hu> wrote: > > * Yinghai Lu <yinghai@kernel.org> wrote: > >> + irq_attr->ioapic = apic; >> + irq_attr->ioapic_pin = mp_irqs[i].dstirq; >> + irq_attr->trigger = irq_trigger(i); >> + irq_attr->polarity = irq_polarity(i); > >> + irq_attr->ioapic = apic; >> + irq_attr->ioapic_pin = mp_irqs[i].dstirq; >> + irq_attr->trigger = irq_trigger(i); >> + irq_attr->polarity = irq_polarity(i); > > Shouldnt this be factored out ino a helper function? > set_io_apic_irq_attr()?
YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |