lkml.org 
[lkml]   [2009]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -rc] [BUGFIX] x86: fix kernel_trap_sp()


    On Tue, 12 May 2009, Robin Holt wrote:
    > > */
    > > -static inline unsigned long kernel_trap_sp(struct pt_regs *regs)
    > > +static inline unsigned long kernel_stack_pointer(struct pt_regs *regs)
    >
    > Why not have it return an unsigned long *?

    I considered it, but since part of the point of the patch was to make it
    look like the mirror of "user_stack_pointer()", returning "unsigned long"
    looked more appropriate.

    But I have no really strong opinions. I wouldn't object to making it
    return "unsigned long *" either.

    Linus


    \
     
     \ /
      Last update: 2009-10-18 23:28    [W:4.339 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site