Messages in this thread | | | Date | Tue, 12 May 2009 07:36:07 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH -rc] [BUGFIX] x86: fix kernel_trap_sp() |
| |
On Tue, 12 May 2009, Robin Holt wrote: > > */ > > -static inline unsigned long kernel_trap_sp(struct pt_regs *regs) > > +static inline unsigned long kernel_stack_pointer(struct pt_regs *regs) > > Why not have it return an unsigned long *?
I considered it, but since part of the point of the patch was to make it look like the mirror of "user_stack_pointer()", returning "unsigned long" looked more appropriate.
But I have no really strong opinions. I wouldn't object to making it return "unsigned long *" either.
Linus
| |