lkml.org 
[lkml]   [2009]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch 1/2] spufs: make dentry reference count and locking symmetric
    Date
    On Tuesday 05 May 2009, jblunck@suse.de wrote:
    > @@ -505,10 +505,7 @@ spufs_create_context(struct inode *inode
    >  out_aff_unlock:
    >         if (affinity)
    >                 mutex_unlock(&gang->aff_mutex);
    > -out_unlock:
    > -       mutex_unlock(&inode->i_mutex);
    >  out:
    > -       dput(dentry);
    >         return ret;
    >  }
    >  

    There is a nasty deadlock problem with spu_forget(), which we
    must call after unlocking i_mutex but before the final dput, IIRC.

    The path down there is something like

    spu_forget -> mmput -> exit_mmap -> remove_vma ->
    fput -> dput -> dentry_iput -> iput -> iput_final ->
    spufs_delete_inode -> destroy_spu_context.

    Arnd <><
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-05-12 16:07    [W:0.027 / U:29.884 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site