Messages in this thread | | | Date | Tue, 12 May 2009 15:42:54 +0200 | From | Ingo Molnar <> | Subject | Re: [tip:sched/core] sched: cpuacct: Use bigger percpu counter batch values for stats counters |
| |
* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> 2009/5/12 Ingo Molnar <mingo@elte.hu>: > > > > * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote: > > > >> > or rather, to make cpuacct_batch have a sane value on UP too. > >> > (1? 0?) > >> > >> umm.. > >> > >> I've reviewed my patch again. > >> but sched_init() already has multiple #ifdef SMP. [...] > > > > Patches are welcome to remove more of them. > > > >> [...] Thus I don't think cosmetic changing improve readability > >> largely. > > > > an avoidable #ifdef should aways be avoided. > > ok. I'll fix it tommorow.
With the caveat that you should do it only if i'm right and if it results in better code in general.
Ingo
| |