[lkml]   [2009]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 11/12] microblaze: dont include asm/mmu.h in hw_exception_handler
Arnd Bergmann wrote:
> On Tuesday 12 May 2009, Michal Simek wrote:
>> 1. Please do not attach your patches - use in-line patches -
>> it is easier for me and for others to review it.
> Something went wrong (again...) with my patches this time, so they
> got rejected by vger. They are not attached however AFAICT, but
> are inline with the "Content-Disposition: inline;" header, which
> is generated by "quilt mail". Which tool do you use that does
> not work with this correctly?

I use sendmail and git-send-email and I use Thunderbird for reviewing.

>> - but on the other hand I need mmu.h for mmu patches - because of MICROBLAZE_TLB_SIZE
>> - if you think that mmu.h shouldn't be included we have to
>> move this definition to another file
>> - you can look at my next branch to see mmu context
> Almost all architectures disallow using mmu.h in assembly, only
> powerpc and sh have an '#ifndef __ASSEMBLY__' in there. I did the
> change to allow using my asm-generic/mmu.h for microblaze-nommu.
> When your MMU code gets merged, this is no longer required though,
> because you cannot simply fall back on the asm-generic version anyway.

I have no problem to remove mmu.h from it but I have to move that one TLB macro to
different sensible include file. It is related with mmu that's why I think someone in past
add it to this file. The main point is which file. Any tip?
Or the second solution is to move directly to .S file but any different include file will be better.


> Arnd <><

Michal Simek, Ing. (M.Eng)
w: p: +42-0-721842854

 \ /
  Last update: 2009-05-12 13:27    [W:0.086 / U:2.668 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site