Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] ata: libata depends on HAS_DMA | Date | Tue, 12 May 2009 11:23:20 +0200 |
| |
On Tuesday 12 May 2009, Alan Cox wrote: > Nakked-by: Alan Cox <alan@linux.intel.com> > > Almost every PATA adapter can fall back to PIO, many are PIO only. We > need a rather cleaner way to sort this.
Currently, the only architectures that don't set HAS_DMA are h8300, m32r m68k (except SUN3 and Coldfire), microblaze and s390. s390 will never get it, microblaze is currently implementing dma-mapping.h.
The other three are still using drivers/ide instead of drivers/ata.
One way to fix this would be to implement dma-mapping.h in h8300, m32r and m68k and leave !HAS_DMA as the obscure s390 case (this one already can't use ATA because of !HAS_MMIO).
The other way would be to add some #ifdef CONFIG_HAS_DMA in libata-core.c and sas_ata.c.
Arnd <><
Arnd <><
| |