lkml.org 
[lkml]   [2009]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [tip:sched/core] sched: cpuacct: Use bigger percpu counter batch values for stats counters

    * Balbir Singh <balbir@linux.vnet.ibm.com> wrote:

    > * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2009-05-12 19:13:42]:
    >
    > > > > +#ifdef CONFIGCONFIG_SMP
    > > > > + cpuacct_batch = jiffies_to_cputime(percpu_counter_batch);
    > > > > +#endif
    > > >
    > > > Slow down and compile patches before sending them out.. please. That
    > > > is a basic expectation if you expect it to be merged.
    > >
    > > Unfortunately, this mistake pass test successfully ;)
    > > it because cpuacct_batch=0 works even SMP.
    > >
    >
    > OK, BTW, using an #ifdef right in the middle of a function makes
    > the code harder to read, can't we use an inline function to
    > abstract out SMP?

    or rather, to make cpuacct_batch have a sane value on UP too. (1?
    0?)

    Ingo


    \
     
     \ /
      Last update: 2009-05-12 12:33    [W:0.021 / U:89.384 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site