Messages in this thread | | | Date | Tue, 12 May 2009 12:29:39 +0200 | From | Ingo Molnar <> | Subject | Re: [tip:sched/core] sched: cpuacct: Use bigger percpu counter batch values for stats counters |
| |
* Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> * KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2009-05-12 19:13:42]: > > > > > +#ifdef CONFIGCONFIG_SMP > > > > + cpuacct_batch = jiffies_to_cputime(percpu_counter_batch); > > > > +#endif > > > > > > Slow down and compile patches before sending them out.. please. That > > > is a basic expectation if you expect it to be merged. > > > > Unfortunately, this mistake pass test successfully ;) > > it because cpuacct_batch=0 works even SMP. > > > > OK, BTW, using an #ifdef right in the middle of a function makes > the code harder to read, can't we use an inline function to > abstract out SMP?
or rather, to make cpuacct_batch have a sane value on UP too. (1? 0?)
Ingo
| |