lkml.org 
[lkml]   [2009]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] x86/pci: add 4 more return param in IO_APIC_get_PCI_irq_vector

* Yinghai Lu <yinghai@kernel.org> wrote:

> @@ -1198,6 +1198,7 @@ int mp_register_gsi(struct device *dev,
> {
> int ioapic;
> int ioapic_pin;
> + struct io_apic_irq_attr io_apic_irq;

please call the variable name 'irq_attr' or so.

> + io_apic_irq.ioapic = ioapic;
> + io_apic_irq.ioapic_pin = ioapic_pin;
> + io_apic_irq.trigger = (triggering == ACPI_EDGE_SENSITIVE ? 0 : 1);
> + io_apic_irq.polarity = (polarity == ACPI_ACTIVE_HIGH ? 0 : 1);
> + io_apic_set_pci_routing(dev, gsi, &io_apic_irq);

I think we've been through this before :-/ Doesnt this:

io_apic_irq.ioapic = ioapic;
io_apic_irq.ioapic_pin = ioapic_pin;
io_apic_irq.trigger = (triggering == ACPI_EDGE_SENSITIVE ? 0 : 1);
io_apic_irq.polarity = (polarity == ACPI_ACTIVE_HIGH ? 0 : 1);

Look nicer?

Also, please do s/triggering/trigger

Thanks,

Ingo


\
 
 \ /
  Last update: 2009-05-11 23:41    [W:1.702 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site