lkml.org 
[lkml]   [2009]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2 v2] kernel/{sched,smp}.c: fix static decl prior to struct declaration

* Jeff Garzik <jeff@garzik.org> wrote:

> Ingo Molnar wrote:
>> -tip testing found this build bug:
>>
>> kernel/sched.c: In function ‘root_task_group_empty’:
>> kernel/sched.c:312: error: ‘root_task_group’ undeclared (first use in this function)
>> kernel/sched.c:312: error: (Each undeclared identifier is reported only once
>> kernel/sched.c:312: error: for each function it appears in.)
>>
>> config attached.
>
> Fixed and resent.

Thanks.

> What a rat's nest of ifdefs! [...]

I warned you :)

> [...] root_task_group is outside CONFIG_USER_SCHED, and so I kept
> that property in patch v3.
>
> However, its definition in kernel/sched.h is conditional on
> CONFIG_USER_SCHED, even though root_task_group_empty() may exist
> outside of CONFIG_USER_SCHED, and root_task_group is referenced vi
> CONFIG_FAIR_GROUP_SCHED || CONFIG_RT_GROUP_SCHED.
>
> Starting to wish I had never patched this code in the first place
> (that barb is directed at the code, not you...)

How would you fix it? People dont like the idea of unconditional
group scheduler, so we cannot remove the variability really.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-05-11 22:55    [W:0.120 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site