Messages in this thread | | | Date | Mon, 11 May 2009 14:34:24 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] Avoid world-writable sysfs files in libata driver |
| |
Vitaly Mayatskikh wrote: > Avoid world-writable sysfs files in libata driver. > > Signed-off-by: Vitaly Mayatskikh <v.mayatskih@gmail.com> > --- > drivers/ata/libata-scsi.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c > index 2733b0c..68d9132 100644 > --- a/drivers/ata/libata-scsi.c > +++ b/drivers/ata/libata-scsi.c > @@ -313,7 +313,7 @@ ata_scsi_em_message_show(struct device *dev, struct device_attribute *attr, > return ap->ops->em_show(ap, buf); > return -EINVAL; > } > -DEVICE_ATTR(em_message, S_IRUGO | S_IWUGO, > +DEVICE_ATTR(em_message, S_IRUGO | S_IWUSR, > ata_scsi_em_message_show, ata_scsi_em_message_store); > EXPORT_SYMBOL_GPL(dev_attr_em_message); > > @@ -366,7 +366,7 @@ ata_scsi_activity_store(struct device *dev, struct device_attribute *attr, > } > return -EINVAL; > } > -DEVICE_ATTR(sw_activity, S_IWUGO | S_IRUGO, ata_scsi_activity_show, > +DEVICE_ATTR(sw_activity, S_IWUSR | S_IRUGO, ata_scsi_activity_show,
applied
| |