Messages in this thread | | | Date | Mon, 11 May 2009 16:29:00 +0900 | From | Minchan Kim <> | Subject | Re: [patch -mmotm] mm: invoke oom killer for __GFP_NOFAIL |
| |
Hi, David.
On Sat, 9 May 2009 15:46:39 -0700 (PDT) David Rientjes <rientjes@google.com> wrote:
> The oom killer must be invoked regardless of the order if the allocation > is __GFP_NOFAIL, otherwise it will loop forever when reclaim fails to > free some memory. >
Hmm.. if __alloc_pages_may_oom fail to allocate free page due to order > PAGE_ALLOC_COSTRY_ORDER,
It will go to nopage label in __alloc_pages_slowpath. Then it will show the page allocation failure warning and will return. Retrying depends on caller.
So, I think it won't loop forever. Do I miss something ?
In addition, the OOM killer can help for getting the high order pages ? -- Kinds Regards Minchan Kim
| |