lkml.org 
[lkml]   [2009]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] ftrace: add a tracepoint for __raise_softirq_irqoff()

On Mon, 11 May 2009, Mathieu Desnoyers wrote:
>
> Yes, we should try to fix TRACE_EVENT, but we should fix it _before_ we
> start using it widely. Circular header dependencies is a real problem
> with TRACE_EVENT right now.
>
> Until we fix this, I will be tempted to stay with a known-good solution,
> which is DECLARE/DEFINE_TRACE.

The majority of tracepoints happen is C files. Those few cases where they
are used in headers is where the issues arise.

But...

I did not want to uglify all trace event headers with:

#ifdef CREATE_FOO_TRACE_POINTS
#undef CREATE_FOO_TRACE_POINTS
#include <trace/define_trace.h>
#endif

We would only need to do that for those trace points that need to be
included in header files. Then the declaration C file would need to define
both CREATE_FOO_TRACE_POINTS and CREATE_TRACE_POINTS

#define CREATE_FOO_TRACE_POINTS
#define CRATE_TRACE_POINTS
#include <trace/events/foo.h>


But this is pretty trivial to solve, and I do not consider it a show
stopper or a major header dependency problem.

-- Steve



\
 
 \ /
  Last update: 2009-05-11 16:11    [W:0.075 / U:5.704 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site