Messages in this thread | | | Date | Mon, 11 May 2009 13:33:56 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/2] CRED: Rename cred_exec_mutex to reflect that it's a guard against ptrace |
| |
* Roland McGrath <roland@redhat.com> wrote:
> > Hmm. Ingo's "rename ptrace_may_access => ptrace_access_check" conflicts > > with my patch too. > > Andrew seemed to want a different name choice too, so that will have to be > resolved before we worry about patch conflicts. > > > Andrew, Roland, I guess I should re-send > > > > ptrace-ptrace_attach-check-pf_kthread-exit_state-instead-of-mm.patch > > ptrace-cleanup-check-set-of-pt_ptraced-during-attach.patch > > ptrace-do-not-use-task_lock-for-attach.patch > > > > patches? > > I guess so too. Your series of changes is more substantial and > potentially controversial or problematic than the various > renamings, so I think it makes sense to settle and merge the > renamings first.
yeah, cleanups first is generally the better strategy. Not only does it make reverts easier, it also makes it easier to review (and potentially fix) later patches.
Ingo
| |