lkml.org 
[lkml]   [2009]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 2/2] Intel-IOMMU, intr-remap: source-id checking
Siddha, Suresh B wrote:
> On Wed, 2009-05-06 at 23:16 -0700, Han, Weidong wrote:
>> @@ -634,6 +694,44 @@ static int ir_parse_ioapic_scope(struct
>> acpi_dmar_header *header, " 0x%Lx\n",
>> scope->enumeration_id, drhd->address);
>>
>> + bus = pci_find_bus(drhd->segment, scope->bus);
>> + path = (struct acpi_dmar_pci_path *)(scope + 1); + count =
>> (scope->length - + sizeof(struct acpi_dmar_device_scope))
>> + / sizeof(struct acpi_dmar_pci_path);
>> +
>> + while (count) {
>> + if (pdev)
>> + pci_dev_put(pdev);
>> +
>> + if (!bus)
>> + break;
>> +
>> + pdev = pci_get_slot(bus,
>> + PCI_DEVFN(path->dev, path->fn));
>> + if (!pdev)
>> + break;
>
> ir_parse_ioapic_scope() happens very early in the boot. So, I don't
> think we can do the pci related discovery here.
>

Thanks for your pointing it out. It should enable the source-id checking for io-apic's after the pci subsystem is up. I will change it.

Regards,
Weidong

\
 
 \ /
  Last update: 2009-05-11 08:27    [W:0.079 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site